Auctioneer tls enablement refactoring #330
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rep and bbs approach
… rep and bbs approach
|
Hey qu1queee! Thanks for submitting this pull request! All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate). When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization. If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions. Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/148742935 The labels on this github issue will be updated when the story is started. |
anoop2811
pushed a commit
to anoop2811/diego-release
that referenced
this pull request
Jul 14, 2017
[finishes #142522481] Submodule src/github.com/onsi/ginkgo c3a655f..67b9df7: > Remove the spec_iterator.test binary (cloudfoundry#336) > Shared queue implementation for parallel tests > Revert "Don't colorize output by default if not writing to a TTY (cloudfoundry#328)" (cloudfoundry#331) > Don't colorize output by default if not writing to a TTY (cloudfoundry#328) > Use SVG badge for build status (cloudfoundry#330) > Add the ability to use ./... to recursively test directories (cloudfoundry#319) > Include captured output from failed tests into JUnit (cloudfoundry#318) > Aggregate flaked specs (cloudfoundry#316) > Add colours for Windows in suite-runner & watch (cloudfoundry#312) > Fix tests for single node machine (cloudfoundry#311) > Add ability to specify a custom bootstrap file (cloudfoundry#302) > Revert "remove -i in invocations of go test. fixes cloudfoundry#305" > Update .travis.yml > fix imports for generate command (cloudfoundry#279) > Merge branch 'koron-windows-colorise' > remove -i in invocations of go test. fixes cloudfoundry#305 > remove unnecessary variable > backfill GinkgoRandomSeed test > Expose the random seed via GinkgoRandomSeed() (cloudfoundry#293) > Include flake count in test summary (cloudfoundry#291) > cloudfoundry#287 Ensure Logf/Skipf insert newline characters (cloudfoundry#288) > Add package path prefix to compilation output path only if missing (cloudfoundry#284) > Redo flags again, add a bunch of pass-throughs. (cloudfoundry#282) > Spelling fix (cloudfoundry#283) > Covermode flag (and reworked pass-through flags passing) (cloudfoundry#281) > Make JUnit reporter include failure location in message. (cloudfoundry#262) > remove 1.4 from travis.yml > Add gcflags option (cloudfoundry#276) > Revert "Use the go1.5 build tag to handle vendor exceptions" (cloudfoundry#274) > Merge pull request cloudfoundry#272 from fsouza/fix-vendor > Add flaky test mitigation (cloudfoundry#261) > Allow units and precision in benchmark (cloudfoundry#266) > Add Solaris support (cloudfoundry#264) > Merge pull request cloudfoundry#259 from kwadrat/master > Merge branch 'apvail-spell-fix' > Fix go16 vendor > Merge pull request cloudfoundry#250 from james-lawrence/master > Merge pull request cloudfoundry#228 from jayunit100/RegexFileNameFiltering > Fix test flakiness Submodule src/github.com/onsi/gomega c463cd2..334b8f4: > Merge pull request cloudfoundry#206 from xoebus/patch-1 > Merge pull request cloudfoundry#205 from onsi/revert-201-json_formatting > Merge pull request cloudfoundry#201 from madamkiwi/json_formatting > Merge pull request cloudfoundry#199 from kevgo/patch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The current approach for enabling the tls communication to the auctioneer server is not so understandable, specially because other core components like
bbsandrepmake this enablement with a different approach(based on a single parameter), e.g.diego.bbs.require_ssl&diego.rep.require_tlsrespectively.The PR proposes to sync
auctioneerin the same way, with a newdiego.auctioneer.require_tlsinstead of the presence of any of this three parameters,diego.auctioneer.ca_cert,diego.auctioneer.server_cert,diego.auctioneer.server_key.This will allow the operator to follow the same approach, when moving to the use of tls/ssl in all diego server components.